Simple recipe to install StatsD and set it up with Librato Metrics backend.#72
Open
krasio wants to merge 5 commits intoengineyard:masterfrom
Open
Simple recipe to install StatsD and set it up with Librato Metrics backend.#72krasio wants to merge 5 commits intoengineyard:masterfrom
krasio wants to merge 5 commits intoengineyard:masterfrom
Conversation
Contributor
|
Hello Krasimir, We reviewed this and need a minor changed added. Change cookbooks/statsd-librato/recipes/default.rb: and cookbooks/statsd-librato/templates/default/monitrc.conf.erb This protects against the case when a user has selected a different username for the environment. This was the only issue we saw in our review. Thank you for writing this and we look forward to merging it soon. |
Author
|
Hi, Changes applied. Thanks for pointing this out to me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.