Conversation
The pack has been served from a stable URL since it was built, and the comment above the download button has said "this is also the link you paste somewhere" the whole time. There was no way to get it out of the page. Sharing a deck meant downloading the .zip and uploading it again wherever you were sharing it - the exact step hosting it was meant to remove. Two buttons, one for each end of that. "Copy pack link" puts the address on the clipboard and kicks the build off, so the first compile is paid by the person who chose to share rather than by the stranger who clicked their link. "Install to my board" opens the recipient's own board with the deck queued. "Send to my board" builds into THEIR OWN queue behind a sign-in, which someone arriving from a shared link has no reason to have; this needs neither, because the board fetches the pack itself. An anchor rather than a button so middle-click still works, which costs a hydration dance: patternsUrl needs the window object and answers "#" without it. The other callers only render after a build, so they are always past that - this one is in server-rendered markup, where "#" would be written into the HTML with no state change to correct it. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A deck's pack has been served from a stable URL since it was built, and the comment above the download button has said "this is also the link you paste somewhere" the whole time — but there was no way to get that link out of the page. Sharing a deck meant downloading the .zip and re-uploading it wherever you were sharing, which is the exact step hosting it was supposed to remove.
Two buttons, one for each end of that:
Send to my boardbuilds into their own queue behind a sign-in, which someone arriving from a shared link has no reason to have; this needs neither, because the board fetches the pack itself. The firmware learned to take a plain.zipat?src=in v3.4.0, so the machinery was already there.An anchor rather than a button, so middle-click and open-in-new-tab still work. That costs a small hydration dance:
patternsUrlneedswindowand answers#without it. The other callers only render after a build has finished and are always past that; this one is in server-rendered markup, where#gets written into the HTML with no state change to correct it. Verified against the served HTML — SSR emits no href, the client fills it in.🤖 Generated with Claude Code