Conversation
…of the box" This reverts commit 0149208.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts the v3.4.1 release commit. @SimonePDA proposed the better shape and it is obviously right:
Runtime configuration, the same way Wi-Fi already works — no credential in the source, none in the image, and each owner points at whatever broker they use. It also removes the question this commit was built to answer.
Exposure, stated plainly. The credentials were on
mainfor about ten minutes (pushed 07:39 UTC, reverted 07:49) and the site auto-deployed, sopatternflow.work/flash/bin/v3.4.1/patternflow.ino.binserved them for roughly six of those. This revert stops new downloads and restores the manifest to v3.4.0. It does not undo what it cannot: anyone who cloned or downloaded inside that window has them, and the values remain in git history — a revert removes them from the tree, not from the objects.So the credential should be treated as exposed and rotated, regardless of how small the window was. That is Simone's to do and he is already reworking the topic permissions.
Not force-rewriting history for this: it breaks every existing clone, and rotation makes the old value worthless anyway, which is the stronger fix. Say the word if you would rather scrub it.
🤖 Generated with Claude Code