Content Thumbnail icon has wrong filter in dark mode #10147

[ashklianko]

• Reverting changes made in Enonic UI: Fix content tree icons in Dark mode #9461: custom icons can be multicolor svgs/pngs, applying filters can make them look worse. Other solutions must be implemented for dark mode icons

[alansemenov]

Can't we tell content type icons from thumbnails? And only apply filter to the former?

[ashklianko]

https://developer.enonic.com/docs/xp/stable/cms/content-types#custom_content_types

Content types may use multicolor svg/png, we can't know how applying filter will result for them.

[ashklianko]

Two potential solution:

1. Add white background behind icons in dark mode (looks bad bad guarantees all icons are seen)
2. Introduce dart mode icons in content types: <content_type_name.ext> icon for standard/fallback (as it is now) and <content_type_name-dark.ext> for dark mode

No filters for thumbnails ofc

[edloidas]

Not sure all those renames are reasonable, since we do not export them, and do not add more similar variables

[ashklianko]

For sake of clarity - to specify it is not mime types but our own content types

[edloidas]

So the problem is with 3rd party icons and images only. I suggest we try drop-shadow instead of other filters for img. Won't look great either, but better than the square border or full background. E.g.:

filter: drop-shadow(0 0 1px rgba(255,255,255,1));