Build error from clearScrollListener #4386#4387
Open
skjulestad wants to merge 2 commits intomasterfrom
Open
Conversation
Fix build warning from clearScrollListener.
alansemenov
reviewed
Mar 30, 2026
Comment on lines
+619
to
+623
| useEffect(() => { | ||
| return () => { | ||
| scrollListenerCleanupRef.current?.(); | ||
| scrollListenerCleanupRef.current = null; | ||
| }; |
Member
There was a problem hiding this comment.
This basically duplicates the code inside const clearScrollListener. If the const is no longer needed/in use - remove it.
Refactor after review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix build warning from clearScrollListener.