Conversation
There was a problem hiding this comment.
Pull request overview
This PR aims to simplify Enonic XP app development by shifting configuration defaults to Gradle properties/providers, introducing a Settings plugin that registers an XP dependency version catalog, and updating plugin behavior/documentation accordingly.
Changes:
- Migrate
AppExtensionto GradleProperty/ListProperty/SetPropertyAPIs and update consumers (AppPlugin,BundleConfigurator) to read values via providers. - Add
com.enonic.xp.settingsSettings plugin to create anxplibversion catalog driven byxpVersion. - Update base plugin defaults (read
xpVersionfromgradle.properties, set Java toolchain convention) and refresh README usage examples.
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
src/main/java/com/enonic/gradle/xp/app/BundleConfigurator.java |
Switches bundle instructions/dev source paths to read from Property-based AppExtension. |
src/main/java/com/enonic/gradle/xp/app/AppPlugin.java |
Sets systemVersion convention from xp extension; updates property access patterns and error text. |
src/main/java/com/enonic/gradle/xp/app/AppExtension.java |
Refactors extension fields to Gradle Provider/Property types and adds conventions from Gradle properties. |
src/main/java/com/enonic/gradle/xp/SettingsPlugin.java |
New settings plugin that registers an xplib version catalog when xpVersion is provided. |
src/main/java/com/enonic/gradle/xp/BasePlugin.java |
Reads XP version via Gradle property and sets Java toolchain language level convention. |
build.gradle.kts |
Publishes the new settings plugin to the Gradle Plugin Portal metadata. |
README.md |
Documents the new plugins, version catalog usage, and property-based defaults. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
rymsha
force-pushed
the
204-simplify-app-development
branch
from
0d67928 to
11adfd6
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 7 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 7 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 7 changed files in this pull request and generated 5 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
No description provided.