Skip to content

Added possibility to specify culture #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
enricobenedos wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Added possibility to specify culture #13

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5ab33e7
Added possibility to specify culture
enricobenedos Oct 3, 2022
1a87bb5
Updated versioning files
enricobenedos Oct 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,11 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [2.1.0] - 2022-xx-xx
### Added

- Possibility to specify the current culture. (#12)

## [2.0.1] - 2021-01-12
### Fixed

Expand Down
4 changes: 2 additions & 2 deletions GPXReaderLib/GPXReaderLib.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,9 @@

<PropertyGroup>
<TargetFramework>netstandard2.0</TargetFramework>
<ReleaseVersion>2.0.0</ReleaseVersion>
<ReleaseVersion>2.1.0</ReleaseVersion>
<Description>The main purpose is to fast read the main info of GPX file. (Tested only with Garmin's GPX)</Description>
<PackageVersion>2.0.0</PackageVersion>
<PackageVersion>2.1.0</PackageVersion>
<Authors>Enrico Benedos</Authors>
<PackageLicenseUrl>https://github.com/enricobenedos/GPXReaderLib/blob/master/LICENSE</PackageLicenseUrl>
<PackageProjectUrl>https://github.com/enricobenedos/GPXReaderLib</PackageProjectUrl>
Expand Down
23 changes: 13 additions & 10 deletions GPXReaderLib/GpxReader.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
using System;
using System.Collections.Generic;
using System.Globalization;
using System.Linq;
using System.Xml;
using System.Xml.Linq;
Expand All @@ -13,11 +14,13 @@ public class GpxReader : IGpxReader
{
private readonly XDocument gpx;
private readonly XmlNamespaceManager xmlNamespaceManager;
private CultureInfo cultureInfo;

public GpxReader(XDocument gpx, XmlNamespaceManager xmlNamespaceManager)
public GpxReader(XDocument gpx, XmlNamespaceManager xmlNamespaceManager, CultureInfo cultureInfo = default)
{
this.gpx = gpx;
this.xmlNamespaceManager = xmlNamespaceManager;
this.cultureInfo = cultureInfo;
}

public string GetGpxName()
Expand All @@ -30,11 +33,11 @@ public double GetElevation(ElevationType elevationType)
switch (elevationType)
{
case ElevationType.Min:
return gpx.XPathSelectElements("//p:gpx//p:trk//p:trkseg//p:trkpt//p:ele", xmlNamespaceManager).Min(x => double.Parse(x.Value));
return gpx.XPathSelectElements("//p:gpx//p:trk//p:trkseg//p:trkpt//p:ele", xmlNamespaceManager).Min(x => double.Parse(x.Value, cultureInfo));
case ElevationType.Max:
return gpx.XPathSelectElements("//p:gpx//p:trk//p:trkseg//p:trkpt//p:ele", xmlNamespaceManager).Max(x => double.Parse(x.Value));
return gpx.XPathSelectElements("//p:gpx//p:trk//p:trkseg//p:trkpt//p:ele", xmlNamespaceManager).Max(x => double.Parse(x.Value, cultureInfo));
case ElevationType.Avg:
return gpx.XPathSelectElements("//p:gpx//p:trk//p:trkseg//p:trkpt//p:ele", xmlNamespaceManager).Average(x => double.Parse(x.Value));
return gpx.XPathSelectElements("//p:gpx//p:trk//p:trkseg//p:trkpt//p:ele", xmlNamespaceManager).Average(x => double.Parse(x.Value, cultureInfo));
default:
return 0.0;
}
Expand Down Expand Up @@ -72,12 +75,12 @@ public double GetElevationGain(double treshold = 0.22)

public DateTime GetStartDt()
{
return gpx.XPathSelectElements("//p:gpx//p:trk//p:trkseg//p:trkpt//p:time", xmlNamespaceManager).Min(x => DateTime.Parse(x.Value));
return gpx.XPathSelectElements("//p:gpx//p:trk//p:trkseg//p:trkpt//p:time", xmlNamespaceManager).Min(x => DateTime.Parse(x.Value, cultureInfo));
}

public DateTime GetEndDt()
{
return gpx.XPathSelectElements("//p:gpx//p:trk//p:trkseg//p:trkpt//p:time", xmlNamespaceManager).Max(x => DateTime.Parse(x.Value));
return gpx.XPathSelectElements("//p:gpx//p:trk//p:trkseg//p:trkpt//p:time", xmlNamespaceManager).Max(x => DateTime.Parse(x.Value, cultureInfo));
}

public TimeSpan GetDuration()
Expand Down Expand Up @@ -117,9 +120,9 @@ public IEnumerable<TrackPoint> GetGpxCoordinates()
List<TrackPoint> gPXCoordinates = new List<TrackPoint>();
for (int i = 0; i < latitudesXAtt.Count; i++) //assume that two lists have same XAttributes count
{
double latitude = double.Parse(latitudesXAtt[i].Value);
double longitude = double.Parse(longitudesXAtt[i].Value);
double elevation = double.Parse(elevationsXEl[i].Value);
double latitude = double.Parse(latitudesXAtt[i].Value, cultureInfo);
double longitude = double.Parse(longitudesXAtt[i].Value, cultureInfo);
double elevation = double.Parse(elevationsXEl[i].Value, cultureInfo);

gPXCoordinates.Add(new TrackPoint(latitude, longitude, elevation));
}
Expand All @@ -139,7 +142,7 @@ public GpxAltimetry GetGpxAltimetry()
//Get list of all registered info record
foreach (TrackPoint trackPoint in GetGpxCoordinates())
{
if(previousTrackPoint == null)
if (previousTrackPoint == null)
{
previousTrackPoint = trackPoint;
}
Expand Down