Skip to content

fix(DataTable): make default row hover visible on dark theme#1279

Merged
e35ventura merged 1 commit into
entrius:testfrom
sunlight7777777:fix/datatable-hover-v3
May 29, 2026
Merged

fix(DataTable): make default row hover visible on dark theme#1279
e35ventura merged 1 commit into
entrius:testfrom
sunlight7777777:fix/datatable-hover-v3

Conversation

@sunlight7777777
Copy link
Copy Markdown
Contributor

Summary

Fixes the invisible row hover state on DataTable. The default used
surface.subtle, which on our dark theme is indistinguishable from
the table background.

Closes #1278

Change

Single-file CSS change in src/components/common/DataTable.tsx:

  • Hover background: surface.subtleborder.subtle
  • Added borderBottom: 1px solid surface.light for row separation
  • Widened transition from background-color to all

This matches the styling TopRepositoriesTable already uses via its
own getRowSx override.

Affected surfaces

  • RepositoryIssuesTable — was broken, now visibly hoverable
  • ✅ Any other DataTable consumer relying on the default — same fix
  • TopRepositoriesTable — no visual change (its consumer-level
    override matches the new default)

Testing

  • Repository → Issues tab: rows highlight on hover, cursor changes
    to pointer, click opens GitHub.
  • Repositories list view: hover behavior unchanged.
  • Lint passes.
  • Type check passes.

##Screenshot
Before Change:

bandicam.2026-05-26.18-34-33-697.mp4

After Change:

bandicam.2026-05-26.18-35-24-742.mp4

@xiao-xiao-mao xiao-xiao-mao Bot added the bug Something isn't working label May 27, 2026
@e35ventura e35ventura merged commit daebf13 into entrius:test May 29, 2026
2 checks passed
@sunlight7777777
Copy link
Copy Markdown
Contributor Author

My prs are merged so have only one open pr now but #1287 pr is still closed
I should create new pr for #1258 ?
@anderdc
@ventura-oss

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] DataTable rows have invisible hover state on dark theme

2 participants