fix(RepoCheck): conditional contributing instructions + typo#1281
Open
sunlight7777777 wants to merge 1 commit into
Open
fix(RepoCheck): conditional contributing instructions + typo#1281sunlight7777777 wants to merge 1 commit into
sunlight7777777 wants to merge 1 commit into
Conversation
The Activity & Feasibility panel always told users to check CONTRIBUTING.md, even when the Community Standards check on the same page flagged it as missing. Now reuses the existing check result and falls back to README guidance when CONTRIBUTING.md is absent. Also fixes 'instructions.l' typo. Closes entrius#1280
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the contradiction on the Repo Check page where the Activity & Feasibility panel always instructed users to check
CONTRIBUTING.md, even when the Community Standards panel on the same page flagged that the file did not exist.Closes #1280
Changes
hasContributingmemo that reuses the existingContributing Guidelinescheck result, so the two panels can never disagree.CONTRIBUTING.mdexists → original sentence, withCONTRIBUTING.mdrendered as a link to the file on the repo's default branch.instructions.ltypo.Testing
Verified on two repos:
infiniflow/ragflow(noCONTRIBUTING.md) → fallback text renders, README link works, Community Standards card stays red ❌.CONTRIBUTING.mdpresent → original text renders, link points to the correct branch, Community Standards card stays green ✓.Screenshots
Before change:
After change: