fix: on-chain upgrade name 3.0.0 -> v3.0.0 (match v2.x naming standard) - #206
Merged
ECHOAD merged 1 commit intoJun 13, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On-chain upgrade name:
3.0.0→v3.0.0Every prior on-chain upgrade name on
passage-2carries thevprefix — the handlerNameconstants arev2.2.0,v2.4.0,v2.5.0,v2.6.0. The3.0.0handler shipped without it. This one-line fix restores the convention so the upgrade name isv3.0.0.(Log strings updated too; the directory/package were already
v3.0.0/v3_0_0.)Validated
Re-ran the real-state fork test on an exported
passage-2snapshot with thev3.0.0name: gov propv3.0.0→ halt at the upgrade height → handlerv3.0.0fires → all module migrations →v3.0.0 upgrade: complete, blocks produced past the height, no panics.Heads-up — this changes the binary, so it needs a re-release
The on-chain name is baked into the binary's handler and must match the gov proposal. The current
v3.0.0release binary has handler name3.0.0. After this merges, please re-cut thev3.0.0release (the existing one is hours old and not yet deployed by any validator) so the tag, the on-chain name, and the upgrade doc all readv3.0.0. The new gov proposal will use namev3.0.0and point--upgrade-infoat the re-cut binary.(The already-submitted proposal #21 used the old name
3.0.0; it can't be cancelled on SDK 0.45, so it will be left to fail on quorum — deposit returns — and superseded by the correctedv3.0.0proposal.)