Skip to content

Remove deprecated MegaethTestnet network#1282

Merged
DZakh merged 3 commits into
mainfrom
claude/relaxed-lamport-H6NSE
Jun 4, 2026
Merged

Remove deprecated MegaethTestnet network#1282
DZakh merged 3 commits into
mainfrom
claude/relaxed-lamport-H6NSE

Conversation

@DZakh
Copy link
Copy Markdown
Member

@DZakh DZakh commented Jun 4, 2026

Removes the deprecated MegaethTestnet (chain ID 6342) network configuration in favor of MegaethTestnet2 (chain ID 6343).

Changes:

  • Removed MegaethTestnet enum variant from the Network enum
  • Removed MegaethTestnet from the network matching logic in the impl Network block

The MegaethTestnet2 variant remains as the active testnet configuration for Megaeth.

https://claude.ai/code/session_018sUFaG1runepaMNvFoRGB7

Summary by CodeRabbit

  • Chores
    • Network configuration updated: "Megaeth Testnet" replaced with "Megaeth Testnet 2" and related chain behavior adjusted.
  • Documentation
    • CLI help updated: removed the old "megaeth-testnet" option from the list of supported blockchains.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Jun 4, 2026

Review Change Stack

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 8b91439f-0567-489b-8d2c-cd958a15457f

📥 Commits

Reviewing files that changed from the base of the PR and between de15d98 and 0b9760c.

📒 Files selected for processing (1)
  • packages/cli/CommandLineHelp.md

📝 Walkthrough

Walkthrough

Replaces Network::MegaethTestnet (6342) with Network::MegaethTestnet2 (6343) in the enum and updates the get_max_reorg_depth match arms; removes megaeth-testnet from the CLI --blockchain documented values.

Changes

Network Chain Identifier Update

Layer / File(s) Summary
Update Network enum variant and reorg depth mapping
packages/cli/src/config_parsing/chain_helpers.rs, packages/cli/CommandLineHelp.md
Network::MegaethTestnet (u64 6342) is replaced with Network::MegaethTestnet2 (u64 6343); get_max_reorg_depth match arm now references MegaethTestnet2; CLI help removes megaeth-testnet from the --blockchain options.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Remove deprecated MegaethTestnet network' accurately and concisely describes the main change in the pull request: removing the deprecated MegaethTestnet variant.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Comment @coderabbitai help to get the list of available commands and usage tips.

@DZakh DZakh enabled auto-merge (squash) June 4, 2026 11:23
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@packages/cli/CommandLineHelp.md`:
- Line 383: The markdown heading "###### **Subcommands:**" at Line 383 jumps
from the higher "##" section and violates MD001; change its level to the next
valid heading level (e.g., "### **Subcommands:**") so it follows the existing
"##" section hierarchy and keeps the document structure consistent.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 8b91439f-0567-489b-8d2c-cd958a15457f

📥 Commits

Reviewing files that changed from the base of the PR and between de15d98 and 0b9760c.

📒 Files selected for processing (1)
  • packages/cli/CommandLineHelp.md

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caution

Inline review comments failed to post. This is likely due to GitHub's internal server error or limits when posting large numbers of comments. If you are seeing this consistently it is likely a permissions issue. Please check "Moderation" -> "Code review limits" under your organization settings.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@packages/cli/CommandLineHelp.md`:
- Line 383: The markdown heading "###### **Subcommands:**" at Line 383 jumps
from the higher "##" section and violates MD001; change its level to the next
valid heading level (e.g., "### **Subcommands:**") so it follows the existing
"##" section hierarchy and keeps the document structure consistent.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 8b91439f-0567-489b-8d2c-cd958a15457f

📥 Commits

Reviewing files that changed from the base of the PR and between de15d98 and 0b9760c.

📒 Files selected for processing (1)
  • packages/cli/CommandLineHelp.md
🛑 Comments failed to post (1)
packages/cli/CommandLineHelp.md (1)

383-383: ⚠️ Potential issue | 🟡 Minor | ⚡ Quick win

Fix heading-level jump at Line 383 (MD001).

###### **Subcommands:** skips heading levels after the ## section and triggers markdownlint. Use the next valid heading level to satisfy lint and keep structure consistent.

🧰 Tools
🪛 markdownlint-cli2 (0.22.1)

[warning] 383-383: Heading levels should only increment by one level at a time
Expected: h3; Actual: h6

(MD001, heading-increment)

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@packages/cli/CommandLineHelp.md` at line 383, The markdown heading "######
**Subcommands:**" at Line 383 jumps from the higher "##" section and violates
MD001; change its level to the next valid heading level (e.g., "###
**Subcommands:**") so it follows the existing "##" section hierarchy and keeps
the document structure consistent.

@DZakh DZakh merged commit ab01468 into main Jun 4, 2026
8 checks passed
@DZakh DZakh deleted the claude/relaxed-lamport-H6NSE branch June 4, 2026 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants