ci: Allow BES uploads to complete before shutting down VMs#2725
Open
alexander-alvarez wants to merge 1 commit intoenvoyproxy:mainfrom
Open
ci: Allow BES uploads to complete before shutting down VMs#2725alexander-alvarez wants to merge 1 commit intoenvoyproxy:mainfrom
alexander-alvarez wants to merge 1 commit intoenvoyproxy:mainfrom
Conversation
https://bazel.build/reference/command-line-reference#flag--bes_upload_mode Signed-off-by: Alex Alvarez <alex@engflow.com>
alexander-alvarez
force-pushed
the
apa/wait-for-upload
branch
from
1397cde to
e2e3904
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change makes it so the Bazel process waits for BEP to upload before returning rather shutting down the VM before the BEP background processes have completed
https://bazel.build/reference/command-line-reference#flag--bes_upload_mode
For an explanation of how to fill out the fields, please see the relevant section
in PULL_REQUESTS.md
Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
[Optional Fixes #Issue]
[Optional Deprecated:]