Fix bug from PR#239 in EnzoMethodPmDeposit#253
Merged
Conversation
PR enzo-project#239 introduced a minor bug in which array used for storing the output of dep_grid_cic was not large enough. This caused dep_grid_cic to write values to invalid locations in memory. This bug manifested in weird ways when using compiling with intel compilers (under special conditions) In addition to fixing that bug, some variable names were updated so that their significance became more apparent
jobordner
approved these changes
Jul 8, 2022
gregbryan
approved these changes
Jul 8, 2022
Contributor
gregbryan
left a comment
gregbryan
left a comment
There was a problem hiding this comment.
This is likely due to the fact that CIC deposition can end up with mass off the edge of the active grid.
tumlinson
approved these changes
Jul 9, 2022
Contributor
tumlinson
left a comment
tumlinson
left a comment
There was a problem hiding this comment.
approved based on success of modest cosmo runs that had previously failed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #239 introduced a minor bug in which array used for storing the output of dep_grid_cic was not large enough. This caused dep_grid_cic to write values to invalid locations in memory. This bug manifested in weird ways when using compiling with intel compilers (under special conditions)
In addition to fixing that bug, some variable names were updated so that their significance is more obvious