#10524 - Refactor: Explicit/implicit Any type clean up from packages\ketcher-core\src\application\ketcher.ts file#10616
Open
AlexeyGirin with Copilot wants to merge 6 commits into
Conversation
Copilot
AI
changed the title
[WIP] Refactor explicit and implicit any types in ketcher.ts
#10524 – Refactor explicit and implicit any cleanup in ketcher core
Jul 18, 2026
…plicit-implicit-any-cleanup-3fc74430-5289-44ee-b212-b135f2b1c45e
AlexeyGirin
marked this pull request as ready for review
July 18, 2026 20:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
How the feature works? / How did you fix the issue?
packages/ketcher-core/src/application/ketcher.tsrelied on loose settings typing and a few untyped values that weakened the public Ketcher API surface. This change narrows those paths to explicit types and aligns the API consumers in autotests with the stricter contract.Typed Ketcher API settings
KetcherApiSettingstyping inketcher.types.tsTightened
ketcher.tssettings flowsettingsgetter result around the supported API-exposed keyssetSettings()against the exported API settings contractRemoved remaining loose values
blobPartunknownand preserved safe error normalizationAligned editor and consumers
Editor.options()/Editor.setOptions()signatures ineditor.types.tsExample of the tightened API shape:
Check list
#1234 – issue name