#10530 - Refactor: Explicit/implicit Any type clean up from packages\ketcher-core\src\application\render\renderers\sequence\SequenceRenderer.ts file#10637
Open
AlexeyGirin with Copilot wants to merge 3 commits into
Open
#10530 - Refactor: Explicit/implicit Any type clean up from packages\ketcher-core\src\application\render\renderers\sequence\SequenceRenderer.ts file#10637AlexeyGirin with Copilot wants to merge 3 commits into
AlexeyGirin with Copilot wants to merge 3 commits into
Conversation
Copilot
AI
changed the title
[WIP] Refactor explicit/implicit any type cleanup in SequenceRenderer.ts
#10530 – Refactor explicit/implicit Any cleanup in SequenceRenderer
Jul 19, 2026
AlexeyGirin
marked this pull request as ready for review
July 19, 2026 07:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
How the feature works? / How did you fix the issue?
SequenceRenderer.tshad implicit/unspecifiedanyin method params and local variables, weakening type safety in sequence editing/rendering flows. This change replaces those with explicit domain-safe types and keeps runtime behavior unchanged.Typed API surface
addNewEmptyChainIfNeeded,shiftArrowSelectionInEditMode).Typed local state in critical paths
number | undefined,SequenceNode | undefined,SequenceBondRenderer,BaseSequenceItemRenderer | undefined).Safer narrowing for renderer resolution
getRendererByMonomerstrict by narrowing withinstanceof BaseSequenceItemRendererbefore assignment.BBox invariant made explicit
Check list
#1234 – issue name