Open
Conversation
|
❌ Build asyn 1.0.312 failed (commit addb1cee25 by @exzombie) |
ericonr
reviewed
Mar 19, 2026
| "asynExceptionConnect", "asynExceptionEnable", "asynExceptionAutoConnect", \ | ||
| "asynExceptionTraceMask", "asynExceptionTraceIOMask", "asynExceptionTraceInfoMask", \ | ||
| "asynExceptionTraceFile", "asynExceptionTraceIOTruncateSize" | ||
| "asynExceptionTraceFile", "asynExceptionTraceIOTruncateSize", "asynExceptionShutdown" |
Contributor
There was a problem hiding this comment.
My only nit is that reviewing would be slightly easier if it followed the same organization as the enum definition above, so "asynExceptionShutdown" would be in its own line.
exzombie
force-pushed
the
add-missing-exception-string
branch
from
b4a6e03 to
9cdda68
Compare
|
❌ Build asyn 1.0.313 failed (commit 943102c14c by @exzombie) |
ericonr
approved these changes
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the mismatch in the length of the
asynExceptionenum and theASYN_EXCEPTION_STRINGSmacro. It also fixes the length check inasynRecord.