Add ASYN_TRACE_INFO#9
Closed
tboegi wants to merge 1 commit intoepics-modules:masterfrom
tboegi:151008_ASYN_TRACE_INFO
Closed
Add ASYN_TRACE_INFO#9tboegi wants to merge 1 commit intoepics-modules:masterfrom tboegi:151008_ASYN_TRACE_INFO
tboegi wants to merge 1 commit intoepics-modules:masterfrom
tboegi:151008_ASYN_TRACE_INFO
Conversation
In case that the traces ASYN_TRACE_FLOW or ASYN_TRACEIO_DRIVER are too spammy, add ASYN_TRACE_INFO This can be used to trace commands send to a device like a motor, or selective status changes.
Member
|
Hi @tboegi I think its a good idea to add another trace flag - we sometimes end up adding an extra custom trace flag like this for specific drivers anyway. However, your patch is lacking a few bits before it is really useful - mainly the bits that lets us control it through the asynRecord. FYI a similar flag (ASYN_TRACE_WARNING) was added in June 2013. The tech-talk discussion is here. If you have a look at the history of that series of commits you can see how the flag was added to the asynRecord. The relevant changes start from commit b605da8 |
Contributor
Author
|
I realize 3 problems:
However, 1) and 2) are addressed here: |
Contributor
Author
|
See #63 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In case that the traces ASYN_TRACE_FLOW or ASYN_TRACEIO_DRIVER
are too spammy, add ASYN_TRACE_INFO
This can be used to trace commands send to a device like a motor,
or selective status changes.