Open
Conversation
Alternative to softMotor.db which uses transform records for the forward calc and all stop calculations
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I like the ability
softMotor.dbgives you to configure a "Soft Channel" motor record at runtime, however I find it very limiting on its own sincecalcoutrecords are used which can only write their outputs to a single PV. For example, say I wanted the soft motor to drive three other motors together. There is no way to tell the soft motor to write its output to three different PVs.Here I propose
softMotorTf.dbas an alternative tosoftMotor.dbwhich usestransformrecords instead ofcalcoutrecords for the$(P)$(SM)CalcFrwdand$(P)$(SM)CalcStopcalculations. It also removes the additionalscalcoutrecords insoftMotor.dbwhich are used to copy links to the underlying calc records in favor of having the user configure the records directly. To configure an instance ofsoftMotorTf.dbthe user must configure the readback(calcout), moving(calcout), output(transform), and stop(transform) calculations.Screens for MEDM and CaQtDM are also included which are slight variations of the softMotor screens. The transform and calcout screens are used from the
calcmodule.