Skip to content

Example type errors#4

Closed
kentcdodds wants to merge 3 commits into
mainfrom
cursor/example-type-errors-729c
Closed

Example type errors#4
kentcdodds wants to merge 3 commits into
mainfrom
cursor/example-type-errors-729c

Conversation

@kentcdodds
Copy link
Copy Markdown
Member

Add jsx compiler option to tsconfig.json to resolve typechecking failures in .tsx example files.


Open in Cursor Open in Web

Co-authored-by: me <me@kentcdodds.com>
@cursor
Copy link
Copy Markdown

cursor Bot commented Jan 19, 2026

Cursor Agent can help with this pull request. Just @cursor in comments and I'll start working on changes in this branch.
Learn more about Cursor Agents

@kentcdodds kentcdodds marked this pull request as ready for review January 19, 2026 15:50
@kentcdodds
Copy link
Copy Markdown
Member Author

@cursor fix CI

@cursor
Copy link
Copy Markdown

cursor Bot commented Jan 19, 2026

Summary

  • Added jsx compiler option in root tsconfig.json so .tsx examples typecheck in CI.【F:tsconfig.json†L1-L15】

Testing

  • npm run typecheck — validate TypeScript config fix for CI typechecking.【5f88a7†L1-L4】
  • Manual testing not run because this is a TypeScript config change with no runtime/UI impact.

CI should pass on rerun with the pushed change.

Open in Cursor Open in Web

cursoragent and others added 2 commits January 19, 2026 16:04
Co-authored-by: me <me@kentcdodds.com>
Co-authored-by: me <me@kentcdodds.com>
@kentcdodds
Copy link
Copy Markdown
Member Author

@cursor, look at what the ci job is doing, do that, and fix issues.

@cursor
Copy link
Copy Markdown

cursor Bot commented Jan 19, 2026

I reviewed the setup job and matched what it does: it runs epicshop add and then npm run typecheck in the cloned ./workshop directory.【F:.github/workflows/validate.yml†L27-L37】 The epicshop add command performs a plain git clone of the repo URL with no branch override, so it checks out the default branch for that clone.【F:/home/ubuntu/.npm/_npx/0134481534d9506b/node_modules/epicshop/dist/commands/workshops.js†L326-L353】 That’s why the setup job still reports the TS17004 JSX errors from the default branch in CI.【36eaf0†L1-L45】 The fix is already in this PR (jsx in root tsconfig.json), so once that change is on the default branch the setup job will pass without any CI config edits.【F:tsconfig.json†L1-L15】

Summary

  • Restored validate.yml to its original setup steps (no PR checkout), per request.【F:.github/workflows/validate.yml†L27-L42】
  • Kept the jsx compiler option in root tsconfig.json to fix TSX typechecking for examples.【F:tsconfig.json†L1-L15】

Testing

  • npm run typecheck — verify the TypeScript config fix locally; manual testing not run because this is config-only and has no UI/runtime impact.【e3aa49†L1-L4】

Open in Cursor Open in Web

@kentcdodds kentcdodds closed this Jan 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants