257 Request URI query string validation#288
Merged
Merged
Conversation
simonoakesepimorphics
changed the base branch from
main
to
235-exception-handling
kal
requested changes
May 15, 2026
| result.add(pair[0], pair[1]); | ||
| if (pair.length > 1) { | ||
| result.add(pair[0], pair[1]); | ||
| } |
Contributor
There was a problem hiding this comment.
Should this add pair[0] if the query parameter is just a name with no value. I believe that is allowed to indicate a boolean true.
Contributor
Author
There was a problem hiding this comment.
Done.
Contributor
There was a problem hiding this comment.
Would be good to also have this branch covered by a test
Contributor
Author
There was a problem hiding this comment.
This code is itself a test utility - I suggest it's outside the scope of what we would normally unit test.
kal
requested changes
May 20, 2026
| result.add(pair[0], pair[1]); | ||
| if (pair.length > 1) { | ||
| result.add(pair[0], pair[1]); | ||
| } |
Contributor
There was a problem hiding this comment.
Would be good to also have this branch covered by a test
kal
approved these changes
May 21, 2026
Contributor
kal
left a comment
kal
left a comment
There was a problem hiding this comment.
Ah ok, I hadn't clocked that the code was in the test branch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #257
Was unable to replicate the issue on the current dev version of ELDA. Added error handling to mitigate this just in case.