feature/playwright e2e#334
Merged
Merged
Conversation
Introduce Node/Yarn tooling scoped exclusively to Playwright browser automation — no impact on the Rails build or asset pipeline. Adds .nvmrc (Node 24), Yarn 4.15.0 via yarnPath, a minimal package.json with @playwright/test, playwright.config.ts targeting port 3001, a reusable setup-node GitHub Action, and a workflow_dispatch e2e.yml workflow. Updates README to document the E2E setup and clarify that Node is only present for test automation.
| description: 'https://github.com/epimorphics/ppd-explorer/issues/335', | ||
| }, | ||
| }, async ({ page }) => { | ||
| test.fixme() |
Contributor
There was a problem hiding this comment.
Is there a ticket to track the two test.fixme() tests
DanielCouzens
approved these changes
May 21, 2026
Contributor
DanielCouzens
left a comment
DanielCouzens
left a comment
There was a problem hiding this comment.
LGTM 👍 just a comment about the fixme()
Contributor
Author
|
One of them has a ticket annotation, the other I've tweaked to not run against the dev environment, so it no longer has the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary