Skip to content

Supports#14

Open
lelami wants to merge 6 commits intomasterfrom
supports
Open

Supports#14
lelami wants to merge 6 commits intomasterfrom
supports

Conversation

@lelami
Copy link
Copy Markdown
Contributor

@lelami lelami commented May 13, 2020

No description provided.

Comment thread primitives/triangle.go

if p1 != nil && p2 == nil && p3 != nil{
return &Line{P1: *p1, P2: *p3}
if (*p1).RoundPlaces(6) != (*p3).RoundPlaces(6) {
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's remove such hardcode. Why 6?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants