This repository was archived by the owner on Nov 3, 2021. It is now read-only.
Adding support to remove a specific listener for an event#6
Open
justinm wants to merge 2 commits into
Open
Conversation
Owner
There was a problem hiding this comment.
Did you mean typeof callback here?
Also, can you update the comment for this function to include the additional argument as well as details for how the argument is used.
Author
There was a problem hiding this comment.
Oops, nice catch! I'll get this fixed up.
Owner
|
Thanks for the PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This could be handy when wanting to remove specific callbacks instead of all callbacks for a given event.