Refactor/first deployment#228
Open
kferjaoui wants to merge 6 commits into
Open
Conversation
- Remove Redis-backed cfg access from globals.py module scope - Avoid cfg.temserver as argparse default (prevents ValueError at startup) - Initialize globals via globals.init() after parsing args and resolving cfg
Entry point (main_ui.py): - Remove graceful fallback for missing Redis connection; fail fast with logging.critical + sys.exit(1) instead - Remove _cfg_get helper - Simplify parameter resolution to: CLI override -> cfg attribute - Update ABOUT_TEXT version description New files: - epoc-config.yaml: default Redis configuration template with documented fields for detector geometry, network endpoints, acquisition settings, and display overlays - init_redis.py: bootstrap script to populate Redis from YAML (flush_db=True) for fresh deployments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The GUI entry point previously caught Redis connection failures and
fell back to CLI defaults. This was misleading i.e. downstream modules
create their own
ConfigurationClientat import time, so the GUIcrashes without Redis regardless. Remove the false resilience: fail
fast with a clear error, simplify parameter resolution to CLI override first,
then to Redis value with
globals.init()Add epoc-config.yaml and init_redis.py so operators can bootstrap
a fresh Redis instance in one step before launching the GUI.
Normalize imports to absolute package paths