Conversation
added affiliations for data-paths
fix DatasetSettings
added 2 commits
December 10, 2025 11:59
- Update ConfigurationClient.fname to assemble the filename from a list of parts - Treat measurement_tag as optional and omit it when empty to avoid double underscores - Preserve existing structure: <file_id>_<project_id>[_<measurement_tag>]_<timestamp>_master.h5
Contributor
Author
|
This update of the |
Use 'affiliation' and eliminate 'experiment_class' from redis
fix: skip empty measurement_tag in generated filenames
Contributor
Author
|
@property
def data_dir(self) -> Path:
# Directory where the current experiment will be stored.
# Computed from the configured experiment
# TODO! Do we need the support for a custom directory
path = Path(self.base_data_dir) / self.affiliation / self.PI_name / self.year / self.project_id / self.today
return path
@property
def work_dir(self) -> Path:
# Directory where output of data analysis will be stored
path = Path(self.base_data_dir) / self.affiliation / self.PI_name / self.year / self.project_id
return path@erikfrojdh or may be you have a cleaner solution? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
space_group_numberargument to latest version ofjfjoch_clientExperiment classwith anAffiliationdrop down menu