Conversation
…ommand line options
…eqasim-java into handle_motorcycles_2025
|
I've added a unit test specifically for motorcycles, I think this should be ok now. One thing to note is that the melun_test case Questions :
|
|
Yes, let's update the config and for the documentation it depends. If there is not any special things to configure beyond the standard elements you mention above (predictor, estimator, ...) I think it is sufficient to have it in the eqasim-synpop. |
|
Ok, fixing tests led to a bunch of other fixes but I think everything is fine now. |
|
@Nitnelav Can you give me access to the branch so I can merge the recent changes? I think somewhere you can click that maintainers of the target repository can make modifications. |
|
Ah it looks like it is only possible for user-based PR, not organization based PR... The conflict is small, do you think I can just resolve it by forcing my changes or do you expect pollutant values to differ ? |
|
I cannot even see what is the conflict via the Github interface. If you can resolve it that would be great. I have some other minor comments, I'll do a quick review. |
There was a problem hiding this comment.
I think these changes don't do anything, revert this?
There was a problem hiding this comment.
I would prefer
Boolean motorcycleAvailability = (Boolean) person.getAttributes().get("useMotorcycle");
if (motorcycleAvailability != null && motorcycleAvailability) {
modes.add(TransportMode.motorcycle);
}
This pull request introduces support for the "motorcycle" transport mode across the core simulation and Ile-de-France scenario modules.
Everything should work properly, even for old simulations without motorcycles. The idea is to enable motorcycles in the simulation only if desired by modifying the config file. this is done in the python pipeline using the EditConfig java class :
Core simulation and configuration updates:
GenerateConfigto enable motorcycle support throughout the configuration pipeline.Motorcycle utility estimation and prediction:
MotorcycleUtilityEstimator,MotorcyclePredictor, andMotorcycleVariablesclasses to provide utility calculation and variable prediction for motorcycle trips.Scenario preparation and network integration:
RunPreparationto allow motorcycles on all links where cars are permitted, ensuring the network supports motorcycle routing.Ile-de-France scenario integration:
IDFModeAvailabilityto check for motorcycle availability based on theuseMotorcycleattribute, and added motorcycle-specific cost models and utility estimators toIDFModeChoiceModule.