[codex] Legalize lesser-body managed deploy template defaults#112
Merged
[codex] Legalize lesser-body managed deploy template defaults#112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Parameters.*.Defaultentries, and document the contractRoot cause
v0.2.3published managed templates that encoded some CloudFormation parameter defaults as intrinsics instead of plain strings.aws cloudformation deployrejects those templates before it can create a change set, so repo-local artifact verification needed to enforce the CloudFormation legality rule directly.Impact
lesser-body-managed-*.template.jsonassets now contain only CloudFormation-legal string defaultsChecks
GOTOOLCHAIN=auto go test ./...GOTOOLCHAIN=auto bash scripts/verify_release_assets.sh v0.0.0-test dist/release-issue106-finalbash scripts/check_release_asset_checksum_regression.sh v0.0.0-test dist/release-issue106-finalbash scripts/check_managed_template_default_regression.sh v0.0.0-test dist/release-issue106-finalruby -e 'require "yaml"; YAML.load_file(".github/workflows/ci.yml"); YAML.load_file(".github/workflows/release.yml")'bash -n scripts/verify_published_release_assets.sh./deploy-lesser-body-from-release.sh --dry-run --no-execute-changeset --stack-name lesser-dev-lesser-body --asset-bucket example-artifacts-bucket --app customapp --stage dev --base-domain example.comfromdist/release-issue106-finalIssue mapping
--no-execute-changesetverification still need the post-merge tag/release step.