fix: accept lesser-body boolean release flags#128
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
falsevalues are accepted instead of treated as empty byjq //source_checkout_requiredandnpm_install_requiredVerification
cd cdk && npm test -- --test-name-pattern 'lesser-body|asset-contract|boolean false manifest flags'jq -r 'if .deploy.source_checkout_required == false then "false" elif .deploy.source_checkout_required == true then "true" else empty end' /tmp/lesser-body-v0.2.3/lesser-body-release.jsonjq -r 'if .deploy.npm_install_required == false then "false" elif .deploy.npm_install_required == true then "true" else empty end' /tmp/lesser-body-v0.2.3/lesser-body-release.jsonbash gov-infra/verifiers/gov-verify-rubric.shGOTOOLCHAIN=auto theory app up --aws-profile Lesser --stage lab --executeRoot Cause
The live
lesser-body v0.2.3release correctly publishessource_checkout_required=falseandnpm_install_required=false, but the runner shell usedjq '.deploy.<flag> // empty'. Injq,false // emptyevaluates toempty, so the runner rejected the valid manifest as if the field were missing.