Skip to content

fix: accept lesser-body boolean release flags#128

Merged
aron23 merged 1 commit intomainfrom
aron/fix-body-release-bool-runner
Mar 31, 2026
Merged

fix: accept lesser-body boolean release flags#128
aron23 merged 1 commit intomainfrom
aron/fix-body-release-bool-runner

Conversation

@aron23
Copy link
Copy Markdown
Contributor

@aron23 aron23 commented Mar 31, 2026

Summary

  • fix the provision runner's lesser-body manifest parsing so boolean false values are accepted instead of treated as empty by jq //
  • add a regression test that pins the boolean-safe buildspec logic for source_checkout_required and npm_install_required
  • deploy the hotfix to lab after verification

Verification

  • cd cdk && npm test -- --test-name-pattern 'lesser-body|asset-contract|boolean false manifest flags'
  • jq -r 'if .deploy.source_checkout_required == false then "false" elif .deploy.source_checkout_required == true then "true" else empty end' /tmp/lesser-body-v0.2.3/lesser-body-release.json
  • jq -r 'if .deploy.npm_install_required == false then "false" elif .deploy.npm_install_required == true then "true" else empty end' /tmp/lesser-body-v0.2.3/lesser-body-release.json
  • bash gov-infra/verifiers/gov-verify-rubric.sh
  • GOTOOLCHAIN=auto theory app up --aws-profile Lesser --stage lab --execute

Root Cause

The live lesser-body v0.2.3 release correctly publishes source_checkout_required=false and npm_install_required=false, but the runner shell used jq '.deploy.<flag> // empty'. In jq, false // empty evaluates to empty, so the runner rejected the valid manifest as if the field were missing.

@aron23 aron23 merged commit 36412b2 into main Mar 31, 2026
12 checks passed
@aron23 aron23 deleted the aron/fix-body-release-bool-runner branch March 31, 2026 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant