feat: certify lesser-body templates through the consumer path#135
Merged
feat: certify lesser-body templates through the consumer path#135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
lesser-bodymanaged templates for deterministic CloudFormation contract violations before the body runner startslesser-bodyreleases through the real consumer path by running the managed helper with--no-execute-changesetand recording the template-certification artifact in managed evidencelesser-bodyhelper and CloudFormation failure detail in operator-visible update state instead of collapsing everything to a generic runner failureWhy
lesser-hostadmittedlesser-body v0.2.3and only learned the published template was invalid after the body runner had already started. That left operators with a late rollout failure instead of an earlier contract rejection, and it hid the actionable CloudFormation error behind a generic runner message.This PR closes that gap by rejecting invalid templates earlier, certifying published templates through the exact consumer path we depend on, and keeping the underlying template/helper failure visible when a rollout still fails.
Impact
lesser-bodyreleases are blocked earlierValidation
GOTOOLCHAIN=auto go test ./internal/provisionworker ./scripts/managed-release-certification ./scripts/managed-release-readiness -count=1cd cdk && npm ci --include=dev && npm run build && node --test dist/test/provision-runner-buildspec.test.jsGOTOOLCHAIN=auto bash gov-infra/verifiers/gov-verify-rubric.shCloses #129
Closes #130
Closes #131
Closes #132
Closes #133
Closes #134