create fileEMDVeloxWithSpectra & update fileEMDVelox's metadata extraction#82
Open
ccatherinetan wants to merge 8 commits intoercius:mainfrom
Open
create fileEMDVeloxWithSpectra & update fileEMDVelox's metadata extraction#82ccatherinetan wants to merge 8 commits intoercius:mainfrom
ccatherinetan wants to merge 8 commits intoercius:mainfrom
Conversation
get latest changes from original repo
ccatherinetan
changed the title
ccatherinetan
force-pushed
the
filEMDVeloxUpdate
branch
from
5705888 to
6413159
Compare
ccatherinetan
force-pushed
the
filEMDVeloxUpdate
branch
from
227f58e to
5727b55
Compare
ercius
reviewed
Apr 7, 2026
| import numpy as np | ||
| import h5py | ||
|
|
||
| def parse_dataset_as_dict(dataset): |
Owner
There was a problem hiding this comment.
can you add a docstring comment as to what this does?
ercius
reviewed
Apr 7, 2026
Owner
|
Have you run the tests for ncempy yet? We need to make sure this does not break anything. It would also be great to add some tests. |
Author
Sorry, I've been a bit busy this past week; I'll try to get to that tonight / tomorrow! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
updates to the
fileEMDVeloxclass:getMetadata: include everything in metaDataJSON except forkeys_to_ignore('EnergyFilter', 'Vacuum', 'GasInjectionSystems')creates new
class fileEMDVeloxWithSpectra, inheriting fromfileEMDVelox_find_groups()to include Image and Spectrum Image data inself.list_datasee most updated description here: MolecularFoundry#3