Correct z_phys and z_ref in MOST for EB.#3113
Merged
asalmgren merged 7 commits intoerf-model:developmentfrom Apr 9, 2026
Merged
Correct z_phys and z_ref in MOST for EB.#3113asalmgren merged 7 commits intoerf-model:developmentfrom
asalmgren merged 7 commits intoerf-model:developmentfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR corrects the calculation of
z_physandz_refin MOST for EB. Since a planar EB does not coincide with the bottom surface of the grid,z_physandz_refare now defined relative to the EB rather than the grid bottom usingz_offset. Meanwhile,k_indicesfor computing the horizontally-averaged velocity remain defined from the bottom.