Skip to content

Upgrade lsp_types and Fix breaking changes#1

Open
GreasySlug wants to merge 3 commits into
mainfrom
upgrade-lsp-types
Open

Upgrade lsp_types and Fix breaking changes#1
GreasySlug wants to merge 3 commits into
mainfrom
upgrade-lsp-types

Conversation

@GreasySlug

@GreasySlug GreasySlug commented Jun 30, 2024

Copy link
Copy Markdown
Member

Upgraded version of 0.93 to 0.97

There were breaking changes and Url was changed to Uri

GreasySlug
GreasySlug commented Jun 30, 2024
View reviewed changes
Comment thread src/lib.rs
Comment on lines +295 to +303
workspace: Some(WorkspaceClientCapabilities {
workspace_folders: Some(true),
..Default::default()
}),
notebook_document: Some(NotebookDocumentClientCapabilities::default()),
window: Some(WindowClientCapabilities::default()),
general: Some(GeneralClientCapabilities::default()),
offset_encoding: None,
experimental: None,

@GreasySlug GreasySlug Jun 30, 2024

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just used default for now

Comment thread src/lib.rs Outdated
@mtshiba mtshiba self-requested a review July 1, 2024 16:25
@mtshiba

mtshiba commented Jul 1, 2024

Copy link
Copy Markdown
Member

The implementation of Url → Uri has changed in lsp_types 0.96.0, but this is a fairly big breaking change.
The impact on molc itself is small on the surface, but the API has been destructively changed.
It turns out that in order for els to follow this update, a significant amount of replacement work will have to be done.
This is also being discussed in the lsp_types issues.

I think it is possible to update to v0.95 right away, but I would like to hold off on whether to follow the changes in v0.96 for a while.

@GreasySlug

GreasySlug commented Jul 2, 2024

Copy link
Copy Markdown
Member Author

The implementation of Url → Uri has changed in lsp_types 0.96.0, but this is a fairly big breaking change. The impact on molc itself is small on the surface, but the API has been destructively changed. It turns out that in order for els to follow this update, a significant amount of replacement work will have to be done. This is also being discussed in the lsp_types issues.

Thank you checking them

I think it is possible to update to v0.95 right away, but I would like to hold off on whether to follow the changes in v0.96 for a while.

OK

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mtshiba mtshiba Awaiting requested review from mtshiba

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@GreasySlug @mtshiba