Open
Conversation
added 4 commits
March 29, 2015 18:26
- tweak default margins for more compact layout
- store open/close state in local storage
- restore open/close state on page refresh
Improve error reporting on test runner page: - display condensed error msg, e.g panic msg and file/line # - hide extended error display, e.g. strack trace and error info - toggle display of extended display when error summary is clicked - reduce width of right col to provide more space for error msg - clear error display when test is run
- make sorting interface private - make local string constants LC - comment out unused code
Owner
Author
|
Hello Guys, Are you interested in additional test page enhancements? I was going to submit a few more changes, e.g. automatically open the panel when clicking on the scroll to error link if it is not visible, but since my previous request was not accepted I'm not sure that you are interested in any additional changes. Please let me know if this is incorrect. Regards, Eric G |
* test suite panel is opened if it is closed and there is an error * vertically center the "Run All Tests" button * remove some log messages * increase size of Run button
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update per comments from annon:
Note: testrunner.go does not follow all the recommendations in the Go formatting guidelines, e.g. local variable names should be sort. Please be specific if there are any additional formatting issues.