feat: improve NixOS compatibility with portable shebang#5
Open
lessuselesss wants to merge 1 commit intoericbuess:devfrom
Open
feat: improve NixOS compatibility with portable shebang#5lessuselesss wants to merge 1 commit intoericbuess:devfrom
lessuselesss wants to merge 1 commit intoericbuess:devfrom
Conversation
- Change #!/bin/bash to #!/usr/bin/env bash in all shell scripts - This allows scripts to work on NixOS and other distributions where bash is not at /bin/bash Files modified: - install.sh - scripts/find_python.sh - scripts/run_python.sh - uninstall.sh
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR improves cross-platform compatibility, particularly for NixOS users, by using portable shebang declarations in shell scripts.
Changes Made
#!/bin/bashto#!/usr/bin/env bashin all shell scripts:install.shscripts/find_python.shscripts/run_python.shuninstall.shWhy This Matters
On NixOS and some other distributions, bash is not located at
/bin/bashbut rather in the Nix store or other locations. Using#!/usr/bin/env bashallows the system to find bash in the PATH, making the scripts work out of the box on these systems.Testing
This is a small but important change that makes the project more accessible to users on alternative distributions.
Related Issues
This addresses the common issue where PROJECT_INDEX installation fails on NixOS due to hardcoded bash paths.