Replace unicode status glyphs with plain ASCII markers - #1
Open
erichanwang wants to merge 1 commit into
Open
Conversation
Checkmarks, crosses, and other unicode symbols in CLI output render as mangled boxes over SSH and in non-UTF-8 terminals, and several of the neuros-* tools were inconsistent about which glyph meant success. Swap them all for plain [ok]/[fail]/[warn] text so output is legible everywhere and greppable. Also fixes two unrelated bugs noticed while touching this code: the Dockerfile's copied entrypoint scripts could lose their execute bit depending on the build context, and .zshrc/hook scripts had a couple of stray glyphs in comments rather than user-facing output.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checkmarks and other unicode glyphs in CLI output render as mangled
boxes over SSH and in non-UTF-8 terminals, and the tools were
inconsistent about which glyph meant success. Swapped all of them for
plain [ok]/[fail]/[warn] text.
Also fixes two small unrelated bugs found while touching this code:
the Dockerfile's copied entrypoint scripts could lose their execute
bit depending on build context, and a couple of stray glyphs sat in
comments rather than user-facing output.
Verified: python3 tests/test_nn.py test_autofix.py test_model.py
test_mcp.py all green, ./validate-build.sh 249/249 passed.