Wire BroadphaseBench into the build, retire a stale doc claim - #3
Open
erichanwang wants to merge 1 commit into
Open
Wire BroadphaseBench into the build, retire a stale doc claim#3erichanwang wants to merge 1 commit into
erichanwang wants to merge 1 commit into
Conversation
broadphase_bench.cpp landed with the spatial-hash broad phase but was never added as a CMake target, so it only ever ran if someone happened to compile it by hand. The README's Known Limitations section also still described the broad phase as an O(n^2) loop after that loop had already been replaced. Added the missing target and replaced the stale line with the actual crossover numbers measured on this machine: the hash is slower below roughly 300 bodies and 22x faster at 10,000, both bracketing the point where the demos here (tens of bodies) sit below the crossover.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
broadphase_bench.cpp landed with the spatial-hash broad phase but was never
added as a CMake target. The README's Known Limitations section also still
described the broad phase as an O(n^2) loop after that loop had already been
replaced.
Added the missing CMake target and replaced the stale doc line with the
crossover numbers measured on this machine: 0.34x at 100 bodies, 1.50x at
1,000, 22.33x at 10,000, bisected crossover around 300 bodies.
No code paths changed; tests still pass (20/20).