feat: add idle logo visibility setting#34
Open
justice-hwan wants to merge 2 commits into
Open
Conversation
Adds an Idle logos setting that affects only the compact rest state, preserving hover peek and expanded layouts while allowing the resting island to shrink to the notch width. Constraint: Issue ericjypark#28 asks to reduce idle notch-adjacent logo footprint without changing hover, expanded, sync, or alert behavior. Rejected: Hide logos in peek or expanded states | those states still need provider context and existing geometry. Confidence: high Scope-risk: narrow Directive: Keep sync sweep and alert glow tied to compact model.size so hidden idle logos still fit the physical notch. Tested: ./scripts/verify.sh
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
🚧 Files skipped from review as they are similar to previous changes (2)
📝 WalkthroughWalkthroughAdds a persisted "Idle logos" preference and UI toggle; ChangesLogo Visibility Control Feature
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ericjypark
reviewed
Jun 3, 2026
ericjypark
left a comment
ericjypark
left a comment
Owner
There was a problem hiding this comment.
Two findings from runtime verification of this PR (built + ran in demo on a built-in notched display and an external monitor). Both are about behavior introduced by the idle-logos toggle; neither blocks the core feature, but #2 is worth a look since it's on-by-default on the display class where it looks worst.
Treat the idle-logo preference as effective only on physical-notch targets so external displays never collapse into an empty synthetic pill. Constraint: Maintainer review found the toggle was exposed and effective on non-notched displays, where hiding logos leaves an empty black pill. Rejected: Delay hover logo animations | review called it minor polish and it would widen scope. Confidence: high Scope-risk: narrow Directive: Keep hover peek and expanded geometry unchanged; only compact notched displays should shrink. Tested: ./scripts/verify.sh
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Idle logossetting on the Display tab.Why
Fixes #28
Testing
Summary by CodeRabbit
New Features
Behavior Changes
Localization