[pull] main from hookdeck:main - #176
Merged
Merged
Conversation
…/RabbitMQ queues (#1033) * feat(mqinfra): allow overriding auto-provisioned DLQ names for SQS/RabbitMQ Adds AWS_SQS_DELIVERY_DLQ/AWS_SQS_LOG_DLQ and RABBITMQ_DELIVERY_DLQ/RABBITMQ_LOG_DLQ so operators whose org naming conventions don't match the hardcoded <queue>-dlq / <queue>.dlq suffixes can set the DLQ name explicitly, instead of working around it externally. Falls back to the existing derived name when unset. Generated with AI Co-Authored-By: Claude <noreply@anthropic.com> * refactor(config): resolve DLQ names in config, log them at startup Addresses review feedback on #1033: - Resolve DLQ names in the config layer's getDLQName() so the effective name is available to callers, and define each provider's naming convention once in mqinfra (DefaultAWSSQSDLQName / DefaultRabbitMQDLQName), used by both layers. The mqinfra DLQ field stays optional and still falls back to the convention, so constructing the infra config directly keeps working as before. - Log the resolved delivery/log DLQ names in the startup configuration summary for SQS and RabbitMQ, per the convention in logging.go. - Add config-layer unit tests for DLQ name resolution: explicit override, fallback to the default, no leaking between queue types, and empty cases. Generated with AI Co-Authored-By: Claude <noreply@anthropic.com> * feat(mqinfra): allow overriding auto-provisioned DLQ names for GCP Pub/Sub Extends the SQS/RabbitMQ DLQ naming config to GCP Pub/Sub, using separate topic and subscription settings to match how GCP names its main resources: GCP_PUBSUB_DELIVERY_DLQ_TOPIC / GCP_PUBSUB_DELIVERY_DLQ_SUBSCRIPTION GCP_PUBSUB_LOG_DLQ_TOPIC / GCP_PUBSUB_LOG_DLQ_SUBSCRIPTION Both are optional and fall back to the existing '<topic>-dlq' and '<dlq-topic>-sub' conventions, now defined once in mqinfra and shared with the config layer. The derived subscription follows the resolved DLQ topic, so overriding only the topic keeps the pair consistent. Azure Service Bus takes no DLQ name settings: it dead-letters into each subscription's built-in $DeadLetterQueue sub-queue, whose name is fixed by the platform. Noted in the config struct so the omission reads as deliberate. Also logs the resolved GCP DLQ names at startup and documents the new settings. Generated with AI Co-Authored-By: Claude <noreply@anthropic.com> --------- Co-authored-by: Ambrozie Paval <ambrozie.paval@flywire.com> Co-authored-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )