[pull] main from livekit:main - #446
Merged
Merged
Conversation
* Consolidate on go.yaml.in/yaml/v3 protocol pulled in two copies of the same yaml library: gopkg.in/yaml.v3 (auth, configutil, livekit/types) and go.yaml.in/yaml/v3 (transitively via buf.build/go/protoyaml). go.yaml.in is the project's new canonical home, so switch our own imports over and compile it once. RoomConfiguration, RoomEgress and RoomAgent needed care. Their custom UnmarshalYAML took a *yaml.Node, and a yaml decoder only recognizes that method if the Node belongs to its own package. Simply re-pointing the import would mean every caller still decoding with gopkg.in/yaml.v3 -- the server, egress, ingress, sip and cloud all do -- silently stops invoking the custom unmarshaller and falls back to reflective struct decoding of a protobuf message. No compile error; fields such as min_playout_delay just quietly come back zero. Instead these now use the func-based unmarshal signature, which names no types from any yaml package and so is honored by both decoders. Downstream repos keep working unchanged, whichever yaml package they import. Added TestUnmarshallRoomConfigurationBothYAMLPackages, which decodes the same document with both packages and asserts a populated message. Verified it fails (min_playout_delay 0 instead of 42) if the *yaml.Node signature is restored. gopkg.in/yaml.v3 stays in go.mod for that test only; it is no longer in the compiled dependency set. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> * Add changeset for consolidating go.yaml.in/yaml/v3 --------- Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )