Skip to content

fix: redact OAuth callback parameters [closes OSWE-259] - #136

Merged
mergify[bot] merged 3 commits into
mainfrom
open-swe/oswe-259-oauth-log-redaction
Aug 5, 2026
Merged

fix: redact OAuth callback parameters [closes OSWE-259]#136
mergify[bot] merged 3 commits into
mainfrom
open-swe/oswe-259-oauth-log-redaction

Conversation

@mobilyze-open-swe-studio2

Copy link
Copy Markdown

Description

Extends the existing boundary-aware log filter to redact exact token, code, and state query parameters while preserving unrelated parameters and current fail-closed behavior.

Release Note

GitHub OAuth callback codes and state values are redacted from covered application access logs.

Test Plan

  • Verified repeated, reordered, encoded, empty, mixed-case, composite-name, nested, URL-object, ASGI, idempotence, and fail-closed cases; lint and typecheck pass.

Closes OSWE-259
Linear: OSWE-259

Made by Open SWE

References

Co-authored-by: open-swe[bot] <open-swe@users.noreply.github.com>

@mobilyze-open-swe-studio2 mobilyze-open-swe-studio2 Bot left a comment

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Open SWE Review found 1 potential issue.

Open in Web

Comment thread agent/logging_redaction.py Outdated
Co-authored-by: open-swe[bot] <open-swe@users.noreply.github.com>
@mergify

mergify Bot commented Aug 5, 2026

Copy link
Copy Markdown

Merge Queue Status

  • Entered queue2026-08-05 20:44 UTC · Rule: default · triggered by merge protections
  • Checks passed · in-place
  • Merged2026-08-05 20:53 UTC · at 47b5b15c46484a5c578630226a8fa662b40dab1f

This pull request spent 9 minutes 12 seconds in the queue, including 8 minutes 23 seconds running CI.

Required conditions to merge
  • github-review-approved [🛡 GitHub repository ruleset rule Mergify automatic merge queue]
  • github-review-approved [🛡 GitHub repository ruleset rule Protect main]
  • all of [🛡 Merge Protections rule Queue ready pull requests]:
  • any of [🛡 GitHub repository ruleset rule Mergify automatic merge queue]:
    • check-success = @mergify/Mergify Merge Protections
    • check-neutral = @mergify/Mergify Merge Protections
    • check-skipped = @mergify/Mergify Merge Protections
  • any of [🛡 GitHub repository ruleset rule Protect main]:
    • check-success = @github-actions/Agent lint
    • check-neutral = @github-actions/Agent lint
    • check-skipped = @github-actions/Agent lint
  • any of [🛡 GitHub repository ruleset rule Protect main]:
    • check-success = @github-actions/Agent format check
    • check-neutral = @github-actions/Agent format check
    • check-skipped = @github-actions/Agent format check
  • any of [🛡 GitHub repository ruleset rule Protect main]:
    • check-success = @github-actions/Agent unit tests
    • check-neutral = @github-actions/Agent unit tests
    • check-skipped = @github-actions/Agent unit tests
  • any of [🛡 GitHub repository ruleset rule Protect main]:
    • check-success = @github-actions/Playwright E2E
    • check-neutral = @github-actions/Playwright E2E
    • check-skipped = @github-actions/Playwright E2E
  • any of [🛡 GitHub repository ruleset rule Protect main]:
    • check-success = @github-actions/lint-pr-title
    • check-neutral = @github-actions/lint-pr-title
    • check-skipped = @github-actions/lint-pr-title
  • any of [🛡 GitHub repository ruleset rule Protect main]:
    • check-success = @github-actions/Analyze (actions)
    • check-neutral = @github-actions/Analyze (actions)
    • check-skipped = @github-actions/Analyze (actions)
  • any of [🛡 GitHub repository ruleset rule Protect main]:
    • check-success = @github-actions/Analyze (javascript-typescript)
    • check-neutral = @github-actions/Analyze (javascript-typescript)
    • check-skipped = @github-actions/Analyze (javascript-typescript)
  • any of [🛡 GitHub repository ruleset rule Protect main]:
    • check-success = @github-actions/Analyze (python)
    • check-neutral = @github-actions/Analyze (python)
    • check-skipped = @github-actions/Analyze (python)
  • any of [🛡 GitHub repository ruleset rule Review gate]:
    • check-success = Open SWE Review
    • check-neutral = Open SWE Review
    • check-skipped = Open SWE Review

@mergify mergify Bot added the queued label Aug 5, 2026
@ericlitman
ericlitman marked this pull request as draft August 5, 2026 20:50
@ericlitman
ericlitman marked this pull request as ready for review August 5, 2026 20:50
@mergify
mergify Bot merged commit c462d05 into main Aug 5, 2026
12 checks passed
@mergify mergify Bot removed the queued label Aug 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant