fix(frontend): resolve set-state-in-effect in SearchAutocomplete (#1063)#1077
Merged
ericsocrat merged 1 commit intomainfrom May 1, 2026
Merged
Conversation
Phase 2 of #1063 -- resolves 2 of 19 violations (running total: 12/19 across 9 PRs). Two react-hooks/set-state-in-effect warnings in SearchAutocomplete.tsx resolved by adjusting state during render: 1. Refresh recent-searches list on dropdown open: replaced the show-dep useEffect with a prevShow render-phase tracker. Added a lazy initial-state initializer so the list is hydrated on mount when show is already true (preserves existing test contract). 2. Reset activeIndex when suggestions/query change: replaced the multi-dep useEffect with a composite resetKey + prevResetKey render-phase tracker. Pattern: https://react.dev/learn/you-might-not-need-an-effect#adjusting-some-state-when-a-prop-changes Behaviour unchanged. 32/32 vitest pass, eslint and tsc clean. Cross-references: #1067, #1069, #1070, #1071, #1072, #1073, #1074, #1075, #1076.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
📸 PR ScreenshotsCaptured 2 screenshots (1 mobile, 1 desktop) for 1 changed page(s):
📥 Download screenshots from workflow artifacts. Captured by PR Screenshots workflow • 2026-05-01 |
Bundle Size Report
✅ Bundle size is within acceptable limits. |
There was a problem hiding this comment.
Pull request overview
This PR continues the Phase 2 cleanup for #1063 by removing react-hooks/set-state-in-effect warnings in SearchAutocomplete via the “adjust state during render” pattern, keeping behavior consistent while making the component React-Compiler-friendly.
Changes:
- Refreshes
recentSearcheson dropdown closed → open transitions using a render-phaseprevShowtracker (and a lazy initializer for initial open renders). - Resets
activeIndexwhen suggestion/query-mode inputs change using a render-phaseresetKey/prevResetKeytracker.
Comment on lines
+185
to
189
| const resetKey = `${suggestions.length}|${debouncedQuery}|${isQueryMode}`; | ||
| const [prevResetKey, setPrevResetKey] = useState(resetKey); | ||
| if (resetKey !== prevResetKey) { | ||
| setPrevResetKey(resetKey); | ||
| setActiveIndex(-1); |
ericsocrat
added a commit
that referenced
this pull request
May 1, 2026
…#1078) Resolves 3 react-hooks/set-state-in-effect violations in src/app/app/search/page.tsx (Phase 2 of #1063): - Mount-load effect: replaced with lazy useState initializers for recentSearches, showAvoided, viewMode (helpers already SSR-safe via globalThis.localStorage guards) - debouncedQuery sync effect: replaced with Pattern A render-phase tracker (composite submitKey of debouncedQuery + filters) - page reset effect: replaced with Pattern A render-phase tracker (composite pageResetKey of submittedQuery + filters) Validated: 54/54 vitest pass, eslint clean, tsc clean. Phase 2 cumulative: 15/19 (final non-deferred multi-violation file). Cross-refs: #1067 (Phase 1), #1069-#1077 (Phase 2 micro-PRs). Co-authored-by: ericsocrat <ericsocrat@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase 2 of #1063 — ninth PR, resolves 11 + 12 of 19 violations.
Two
react-hooks/set-state-in-effectwarnings inSearchAutocomplete.tsxresolved by adjusting state during render instead of insideuseEffect:[show]effect with aprevShowrender-phase tracker. Added a lazy initializer sorecentSearcheshydrates on mount whenshowis already true (preserves existing test expectations around initial render).resetKey/prevResetKeytracker.Pattern reference: https://react.dev/learn/you-might-not-need-an-effect#adjusting-some-state-when-a-prop-changes
Behaviour unchanged. 32/32 vitest pass, eslint and tsc clean.
Cross-references prior Phase 2 PRs: #1067, #1069, #1070, #1071, #1072, #1073, #1074, #1075, #1076.