-
Notifications
You must be signed in to change notification settings - Fork 0
fix(search): polish action bar tooltips and enhance empty state (#983) #987
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||
|---|---|---|---|---|---|---|---|---|
|
|
@@ -421,6 +421,7 @@ export default function SearchPage() { | |||||||
| }} | ||||||||
| className="touch-target flex items-center gap-1.5 text-xs text-foreground-secondary hover:text-foreground" | ||||||||
| aria-label={t("search.toggleViewMode")} | ||||||||
| title={t("search.toggleViewMode")} | ||||||||
| > | ||||||||
| {viewMode === "list" ? ( | ||||||||
| <LayoutGrid size={14} aria-hidden="true" className="inline" /> | ||||||||
|
|
@@ -442,6 +443,7 @@ export default function SearchPage() { | |||||||
| type="button" | ||||||||
| onClick={() => setShowSaveDialog(true)} | ||||||||
| className="touch-target text-xs text-foreground-muted hover:text-brand" | ||||||||
| title={t("search.saveSearch")} | ||||||||
| > | ||||||||
| <Save size={14} aria-hidden="true" className="inline" />{" "} | ||||||||
| <span className="hidden xs:inline"> | ||||||||
|
|
@@ -454,6 +456,7 @@ export default function SearchPage() { | |||||||
| <Link | ||||||||
| href="/app/search/saved" | ||||||||
| className="touch-target text-xs text-foreground-muted hover:text-brand" | ||||||||
|
||||||||
| className="touch-target text-xs text-foreground-muted hover:text-brand" | |
| className="touch-target text-xs text-foreground-muted hover:text-brand" | |
| aria-label={t("search.savedSearches")} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test asserts accessibility via
getByTitle, buttitleis not a reliable accessibility mechanism and isn’t exposed consistently through the accessibility tree. After adding anaria-label/accessible name on the Saved Searches link, prefer asserting withgetByRole('link', { name: ... })instead.