fix(cache): fall through to @import traversal on global-index miss (#20)#27
Merged
Merged
Conversation
findMethodCrossFile returned null as soon as the global type index had no matching (type, method), reaching the @import-graph traversal only when the index ERRORED (OOM). But the global index is built from the project walk, which skips vendor/build/cache dirs — so a type reachable through the file's own @import declarations, yet living in a skipped dir, failed to resolve even though the import path is right there. A global-index miss is not proof the type is unreachable. Now an index miss falls through to the @import traversal instead of giving up. Bounded: findMethodAcrossImports caches the result (incl. the negative), so the traversal runs at most once per (type, method) per file; the fast path (index hit) is unchanged. This also removes the long-standing flakiness of the cross-file unit tests: tmp fixtures under .zig-cache are skipped by the project walk, so they only resolved when the index happened to error. The cross-file ownership tests (#20) are tightened from best-effort `if`-guards to deterministic assertions, verified load-bearing by neutering the fall-through (the strict transitive test then fails to resolve). Refs #20
ericsssan
added a commit
that referenced
this pull request
Jun 11, 2026
Propagate the transitive effect flags (may_grow_collections / may_invoke_gc / may_run_on_any_thread) across @import edges, and unify the three near-identical same-file phases into one generic pass. - The three propagate*One phases (Phase 5/6/7) collapse into propagateEffectOne(fn_decl, receiver_type, comptime Effect). Besides removing ~90 lines of duplication, it now also follows METHOD calls (`recv.method()`) — the old phases handled bare calls only and skipped method calls entirely. recv is resolved to its type (param via paramContainerName, or the enclosing type for self/this), then the callee summary is looked up same-file (summaryByMethod) or cross-file (summaryByMethodCrossFile). - summaryByMethodCrossFile now carries the callee's DIRECT effect flags (via inferFromBody — cheap, body-level, no foreign-file propagation), and CachedTakes is extended to cache them so a cache hit doesn't drop them. So a fn that calls an imported method which grows a collection (etc.) now inherits the effect. Bound: cross-file effects are DIRECT-only — a foreign method that merely delegates the effect to its own callee isn't followed (effects are narrow-value; transitive-within-foreign-file is deferred). Tests: same-file may_grow via self.method() (new method leg), and cross-file may_grow via an imported g.add() (deterministic since the #27 @import-fallback fix). Both verified load-bearing by neutering the cross-file effect copy (only the cross-file test then fails). Refs #20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
findMethodCrossFilereturnednullas soon as the global type index had no matching(type, method)— reaching the@import-graph traversal only when the index errored (OOM). But the global index is built from the project walk, which deliberately skipsvendor//build//cachedirs. So a type that's reachable through the file's own@importdeclarations, yet lives in a skipped dir, failed to resolve — even though the import path is right there. A global-index miss is not proof the type is unreachable.Fix
On an index miss, fall through to the
@importtraversal instead of returning null. The fast path (index hit) is unchanged. Bounded:findMethodAcrossImportscaches the result including the negative, so the traversal runs at most once per(type, method)per file.Why this matters beyond tests
.zig-cacheare skipped by the project walk, so the cross-file unit tests previously only resolved when the index happened to error (environment-dependent). That flakiness is now gone — the Inter-procedural analysis bounded to 1 import hop / private free fns #20 cross-file ownership tests are tightened from best-effortif-guards to deterministic assertions.Verification
zig build+ fullzig build testgreen.return null) makes the strict transitive-takes test fail withCrossFileResolutionFailed.Refs #20.