deps: Bump SQLitePCLRaw.bundle_e_sqlite3 from 2.1.12 to 3.0.4 - #407
Conversation
--- updated-dependencies: - dependency-name: SQLitePCLRaw.bundle_e_sqlite3 dependency-version: 3.0.4 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
LabelsThe following labels could not be found: Please fix the above issues or remove invalid values from |
erikdarlingdata
left a comment
There was a problem hiding this comment.
Summary
Dependabot bump of SQLitePCLRaw.bundle_e_sqlite3 from 2.1.12 → 3.0.4 in server/PlanShare/PlanShare.csproj. One-line change.
What's good
- Direct ref is still the right shape while
Microsoft.Data.Sqlitefloors below 2.1.12; the bump keeps the CVE-2025-6965 mitigation intact and moves further ahead. - Dependabot config correctly keeps majors out of the
patch-and-minorgroup, so this arrived as its own PR rather than buried in a batch — that's working as intended.
Needs attention
-
Base branch is
main, notdev. The repo's active development branch isdev(protected, perlist-branches) and other feature PRs on this repo targetdev..github/dependabot.ymlhas notarget-branch:set, so every Dependabot PR defaults to the repo default (main) — #406 has the same problem. Either retarget this PR todevbefore merging, or addtarget-branch: devunder eachupdates:block in.github/dependabot.ymlso future bumps land on the right branch. Flagging this on every Dependabot PR until the config is fixed is going to get noisy. -
Major version bump on a native-bundle package. See inline on
PlanShare.csproj:14. The managed API ofbundle_e_sqlite3is stable across the 2→3 jump but the underlying package graph changed (SQLitePCLRaw.lib.e_sqlite3→SourceGear.sqlite3) and the native binary moved to SQLite 3.53.3. Worth a runtime smoke of PlanShare on Linux/macOS/Windows before merge — CI restore + build passing isn't sufficient for a native-asset bump. -
Stale rationale comment. L11–13 argue for the direct ref in terms of a CVE fix at 2.1.12 and "remove this once its floor reaches 2.1.12+". After this bump the comment reads as an argument to delete the pin, which would regress the version. Rewrite the intent if this lands.
No PlanAnalyzer changes, no Avalonia/XAML changes, no src/ logic changes — none of the Studio-specific gotchas apply.
Not approving / not requesting changes — comments only.
Generated by Claude Code
| <!-- Direct ref lifts the transitive SQLitePCLRaw above 2.1.11, which bundles a | ||
| SQLite vulnerable to CVE-2025-6965 (GHSA-2m69-gcr7-jv3q). Microsoft.Data.Sqlite | ||
| still floors at 2.1.11 — remove this once its floor reaches 2.1.12+. --> | ||
| <PackageReference Include="SQLitePCLRaw.bundle_e_sqlite3" Version="2.1.12" /> | ||
| <PackageReference Include="SQLitePCLRaw.bundle_e_sqlite3" Version="3.0.4" /> |
There was a problem hiding this comment.
This is a major version bump (2.1.12 → 3.0.4) on a package that ships the native SQLite binary. Per the upstream v3 release notes the package ID of SQLitePCLRaw.lib.e_sqlite3 was renamed to SourceGear.sqlite3 and the bundled native was moved to SourceGear.sqlite3 3.53.3, so restore/lock/pack outputs will change even though the managed API surface for bundle_e_sqlite3 is stable. Worth a manual smoke of PlanShare against a real SQLite DB on every OS you ship (esp. Linux, where native-asset RIDs regress most often — see the SkiaSharp pin in .github/dependabot.yml).
The rationale comment on L11–13 is now stale: the CVE-2025-6965 mitigation reason no longer describes intent (we're far past 2.1.12), and "remove this once its floor reaches 2.1.12+" would now argue for removing the direct ref, which would silently drop us back to whatever transitive Microsoft.Data.Sqlite carries (still 2.1.11 per that comment). If this bump lands, rewrite the comment to state the new intent — pinning to 3.x ahead of Microsoft.Data.Sqlite — otherwise a future cleanup will delete the ref for the wrong reason.
Generated by Claude Code
The comment said "remove this once its floor reaches 2.1.12+", which is stale now that the ref is on the 3.x line. Microsoft.Data.Sqlite 10.0.10 still floors its transitive at the vulnerable 2.1.11, so this direct ref is still what keeps the native library patched. Records what was verified: 3.0.4 bundles SQLite 3.53.3 (past the 3.50.2 CVE fix), and Microsoft.Data.Sqlite 10.0.10 works against the 3.x native layer - stats aggregates, insert, select round-trip, parameterized delete, and 404-after-delete all exercised against a running instance. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Verified this beyond a green build, since the real risk here is runtime rather than compile-time.
What I testedBuilt PlanShare on 3.0.4, ran the actual binary, and exercised every SQL path in
No provider registration failure, no runtime error. CVE status holds3.0.4 bundles SQLite 3.53.3, well past the 3.50.2 that fixes CVE-2025-6965. So this keeps the fix that the original 2.1.12 pin was added for. One extra commitI updated the comment above the ref. It said "remove this once its floor reaches 2.1.12+", which is stale now the ref is on the 3.x line - and misleading, because Note on deployment
|
|
Reviewed. This is a minimal, low-risk dependency bump (2 lines in
No issues found. |
Updated SQLitePCLRaw.bundle_e_sqlite3 from 2.1.12 to 3.0.4.
Release notes
Sourced from SQLitePCLRaw.bundle_e_sqlite3's releases.
3.0.4
Update SQLitePCLRaw.bundle_e_sqlite3 to reference SourceGear.sqlite3 version 3.53.3.
3.0.3
Fixes for some fairly obscure memory corruption bugs, thanks for PR #663 and related
3.0.2
Update SourceGear.lib dependency to 3.50.4.2
3.0.1
SQLitePCLRaw.lib.e_sqlite3toSourceGear.sqlite33.0.0
v3 release notes
Commits viewable in compare view.
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)