Skip to content

Release 0.12.3 and fix Atalui Bloodletting scaling#4

Merged
eriksegecs merged 2 commits into
devfrom
codex/edit-atalui-s-bloodletting-lineage-support-sv6yzp
Dec 7, 2025
Merged

Release 0.12.3 and fix Atalui Bloodletting scaling#4
eriksegecs merged 2 commits into
devfrom
codex/edit-atalui-s-bloodletting-lineage-support-sv6yzp

Conversation

@eriksegecs
Copy link
Copy Markdown
Owner

Summary

  • cap Atalui's Bloodletting per-20-Life scaling so the extra physical damage tops out at 40%
  • refresh exported data and changelog entry for the new gem behavior
  • bump the manifest to version 0.12.3 with updated hashes

Testing

  • not run (not requested)

Codex Task

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/Data/Skills/sup_str.lua Outdated
Comment on lines +543 to +544
["gain_%_of_damage_as_physical_per_20_life_cost"] = {
mod("DamageGainAsPhysical", "BASE", nil, 0, 0, { type = "PerStat", stat = "LifeCost", div = 20, limit = 20, limitTotal = true }),
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Correct Bloodletting cap to match 40% text

The new stat map for Atalui’s Bloodletting sets limit = 20 on the per-life PerStat tag, and because limitTotal clamps the final mod value (see ModStore: limitTotal handling), the extra physical gain caps at 20% instead of the intended 40%. With a Life cost of 400 or more, the mod computes 2% × 20 = 40% but is immediately clamped to 20%, contradicting the changelog and the stat description (“up to 40%”). The limit should reflect the 40% cap rather than 20%.

Useful? React with 👍 / 👎.

@eriksegecs eriksegecs merged commit b666eff into dev Dec 7, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant