Release 0.12.3 and fix Atalui Bloodletting scaling#4
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| ["gain_%_of_damage_as_physical_per_20_life_cost"] = { | ||
| mod("DamageGainAsPhysical", "BASE", nil, 0, 0, { type = "PerStat", stat = "LifeCost", div = 20, limit = 20, limitTotal = true }), |
There was a problem hiding this comment.
Correct Bloodletting cap to match 40% text
The new stat map for Atalui’s Bloodletting sets limit = 20 on the per-life PerStat tag, and because limitTotal clamps the final mod value (see ModStore: limitTotal handling), the extra physical gain caps at 20% instead of the intended 40%. With a Life cost of 400 or more, the mod computes 2% × 20 = 40% but is immediately clamped to 20%, contradicting the changelog and the stat description (“up to 40%”). The limit should reflect the 40% cap rather than 20%.
Useful? React with 👍 / 👎.
Summary
Testing
Codex Task