feat: disabled volume buttons when volume goes to 100 or 0#1629
Open
krakenftw wants to merge 2 commits intoeritislami:masterfrom
Open
feat: disabled volume buttons when volume goes to 100 or 0#1629krakenftw wants to merge 2 commits intoeritislami:masterfrom
krakenftw wants to merge 2 commits intoeritislami:masterfrom
Conversation
Added checks while changing volume, on 100 volume the volume up button is disabled and same for volume 0. Improves UX and removes the interaction failed as showed in eritislami#1628 fix eritislami#1628
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added checks while changing volume, on 100 volume the volume up button is disabled and same for volume 0. Improves UX and removes the interaction failed as showed in #1628
fix #1628