Open
Conversation
wasserfeder
reviewed
Jun 29, 2024
Collaborator
wasserfeder
left a comment
wasserfeder
left a comment
There was a problem hiding this comment.
Looks good. Please test the changes we made: moving stl to a subpackage, and adding the mtl subpackage.
| @@ -86,7 +86,7 @@ def add_state(self, state, t): | |||
| name='{}_{}'.format(state, t) | |||
| v = self.model.addVar(vtype=vtype, lb=low, ub=high, name=name) | |||
| self.variables[state][t] = v | |||
| print 'Added state:', state, 'time:', t | |||
Collaborator
There was a problem hiding this comment.
We should delete this print statement.
| @@ -0,0 +1,26 @@ | |||
| from setuptools import find_packages, setup | |||
Collaborator
There was a problem hiding this comment.
Should we move towards the newer packaging methodology using a pyproject.toml file, pip as frontend and setuptools as backend.
Collaborator
Author
There was a problem hiding this comment.
I talked to Jaime about this, and he says that you could do that, but it's probably not necessary for a project of this size.
…yTeLo into feature/pip-install
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Cristi et al.,
We're trying to clean up code on our end - particularly removing our internal copy of
python-stlin favor of pointing topytelo. Seems one of the things that would make this a lot easier is ifpytelowas pip-installable, so that external code can import its functions without referencing file paths. We're not sure if you want to actually merge this PR or just keep it a separate branch, but we figured we'd at least push and let you know that this was done in case you wanted to take advantage of it.(Also fixed a minor Python 2-style print statement in
stl2milp.py.)