fix: return query_timeout instead of closed on deadline#124
Open
Taure wants to merge 1 commit intoerleans:mainfrom
Open
fix: return query_timeout instead of closed on deadline#124Taure wants to merge 1 commit intoerleans:mainfrom
Taure wants to merge 1 commit intoerleans:mainfrom
Conversation
When a pool deadline fires during query execution, the socket is
closed and recv returns {error, closed}. This is indistinguishable
from actual connection failures. Now detect deadline-triggered
disconnects by checking if the holder ETS table was deleted, and
return {error, query_timeout} instead.
Closes erleans#96
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
recvreturns{error, closed}, which is indistinguishable from actual connection failures{error, query_timeout}instead{error, einval}which can occur in the same scenario depending on timingCloses #96
Test plan
query_timeouttest added to pgo_SUITE — verifiespg_sleep(5)with 500ms timeout returns{error, query_timeout}