Skip to content

Stop redirect loops#499

Open
avtobiff wants to merge 1 commit into
erlyaws:masterfrom
avtobiff:stop-redirect-loop
Open

Stop redirect loops#499
avtobiff wants to merge 1 commit into
erlyaws:masterfrom
avtobiff:stop-redirect-loop

Conversation

@avtobiff
Copy link
Copy Markdown
Collaborator

Stop redirects if the server path equals redirect path. This stops redirect loops.

@vinoski
Copy link
Copy Markdown
Collaborator

vinoski commented Jan 15, 2025

Looks like redirect_with_trailing_slash is failing.

Can we also add a new test for redirect loops?

@avtobiff
Copy link
Copy Markdown
Collaborator Author

Yes, I mixed up Prefix and Path when creating this change.
Should be fixed in last push.

Wlil work on a test.

Stop redirects if the server path equals redirect prefix path. This
stops redirect loops.
@avtobiff
Copy link
Copy Markdown
Collaborator Author

Finally using the correct path (the (#arg.req)#http_request.path), but
the redirect is still failing. Needs more work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants