Skip parentheses containing acronyms with three to five characters#59
Open
network-charles wants to merge 1 commit intoerrata-ai:masterfrom
Open
Skip parentheses containing acronyms with three to five characters#59network-charles wants to merge 1 commit intoerrata-ai:masterfrom
network-charles wants to merge 1 commit intoerrata-ai:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @jdkato, the current parentheses rule is too broad, it displays a vale suggestion for all use of parentheses. However, the Acronym rule captures 3–5 uppercase abbreviations, and it isn't accounted for in the parentheses rule.
The unaccounted abbreviation limit has been resolved in this PR. Words with acronyms in a parentheses won't require a parentheses suggestion anymore since it adheres with the abbreviation and parentheses rules.
One example is
National Aeronautics and Space Administration (NASA).